Update/store retrieve list seperation#272
Conversation
Reviewed the latest commit ( Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
There was a problem hiding this comment.
Pull request overview
This PR separates peer eligibility into two distinct allowlists—one for routing/read lookups and one for store/write replication—so postponed peers can still participate in routing while only active peers are used as write targets.
Changes:
- Introduces a new
storeAllowlistandeligibleForStoregating alongside updated routing/read eligibility semantics. - Updates store paths (
storeToAlphaNodes,IterateBatchStore,batchStoreNetwork) to skip non-store-eligible peers and improves batch-store error reporting. - Adjusts bootstrap syncing to produce both routing (Active+Postponed) and store (Active-only) allowlists, and updates ping-success handling to reflect the new split.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
p2p/kademlia/dht.go |
Adds store allowlist + store eligibility checks; changes routing eligibility behavior; updates batch store candidate selection; disables delete/cleanup workers. |
p2p/kademlia/bootstrap.go |
Extends chain bootstrap to compute routing vs store allowlists and wires them into the DHT. |
p2p/kademlia/node_activity.go |
Updates ping success logic to add nodes to routing while only marking “Active” when store-eligible. |
p2p/kademlia/dht_batch_store_test.go |
Updates expected error substring for the new batch-store failure message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.