-
Notifications
You must be signed in to change notification settings - Fork 24
Update version 6.10.4 #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds a v6.10.4 release entry to the changelog describing a Minor Reflected SSRF fix and updates the announcement widget to reference v6.10.4. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/components/widgets/Announcement.astro (1)
12-15: Release link update looks correct; consider consistent external-link behavior.
The updated tag URL and text match v6.10.4. If you intend external GitHub links to open in a new tab (like the stars badge link does), consider addingtarget="_blank"+rel="noopener"here too for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/releases.md (1)
39-41: Minor grammar refinements needed for release note clarity (user-facing documentation).The security section has improved since the previous review, but two small issues remain:
Line 39: "We have been reported" is passive and awkward. Consider: "We were notified" or "A vulnerability was reported to us."
Line 41: "...against local network etc." is informal for a security advisory. Consider: "...against local networks and similar targets" or expand the thought to be more explicit about what "etc." covers.
These are minor polish issues for a user-facing release document where clarity is important.
-We have been reported (CVE incoming) that a minor SSRF vulnerability was still present in Lychee. +We were notified (CVE incoming) that a minor SSRF vulnerability was still present in Lychee.-Validation is done on the initial URL; however, if the URL is redirected, the redirection target was not validated against local network etc. +Validation is done on the initial URL; however, if the URL is redirected, the redirection target was not validated against local networks and similar internal resources.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
docs/releases.md(1 hunks)
🔇 Additional comments (1)
docs/releases.md (1)
33-53: Release entry is well-structured and addresses previous review feedback.The v6.10.4 security note has incorporated most corrections from the prior review:
- ✓ Fixed "incomming" → "incoming"
- ✓ Fixed "as an edge cases as not considered" → "because an edge case had not been considered"
- ✓ Improved clarity of the validation sentence
The section now reads much more clearly than the previous iteration. The format, headers, and changelog link are all correct.
Summary by CodeRabbit
Bug Fixes
New Features
Documentation
Acknowledgements
✏️ Tip: You can customize this high-level summary in your review settings.