GH-686 Limits on rate-pack values

[dnwiebe]

Note

Adds bounded pricing support and related robustness changes.

• Database/Config: Bump CURRENT_SCHEMA_VERSION to 12; new migration 11→12 inserts default rate_pack_limits; DbInitializer seeds rate_pack_limits; ConfigDaoNull supplies defaults; PersistentConfiguration now parses/validates rate_pack_limits (with ordering checks) and exposes a factory; SetupReporter updates rate-pack example values
• Accounting: Centralize total-charge computation (total_charge) and pass it through to recorders; logs now include wei amounts; tests updated accordingly
• Neighborhood/Gossip/Rendering: NodeRenderable field renamed to node_addr_opt; improve gossip record Display and helpers (agrs_to_string); minor test expectation updates
• Infra/Tests: Multinode Docker network creation made more reliable (remove-if-exists + retries); integration tests use more nodes, longer timeouts, different test hosts, and higher RatePack values to match new limits; stabilize connection progress waits
• Misc: Enable time crate local-offset feature; add SWEEP.md; minor bootstrapping and .gitignore tweaks

^{Written by Cursor Bugbot for commit 9313296. This will update automatically on new commits. Configure here.}

[czarte]

I am still uncertain, this will protect the MASQ Foundation network, because if someone want's to set rate-pack below the limit, it is just one change and cargo build away from doing so and network does not even aknowledge this. I woud like to propose: make an debut_handler rule, that if the debuting node is in standard, or originate-only mode, and have rate pack below (or above) the limits, his debut is dropped on the flor

[cursor]

Bug: Regex Capture Error Message Mismatch

The parse_capture function's error message "Internal error: regex needs four captures" is incorrect. The RATE_PACK_LIMIT_FORMAT regex actually has 8 capture groups, not 4. This generic message also makes debugging difficult by not indicating which of the 8 expected fields is missing.

 

[kauri-hero]

Hey @dnwiebe @czarte - I agree with @czarte comments to add this additional checking in the handlers to ensure Nodes don't have rate-packs outside of the defined limits now, and can be done without too much additional work.

This will cover older versions of Node joining network with rates outside the hard-coded limits

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[cursor]

Two test assertions commented out reducing test coverage

Medium Severity

The test function data_can_be_routed_using_different_min_hops has two assertions commented out for Hops::OneHop and Hops::TwoHops, leaving only Hops::SixHops tested. While there's a comment mentioning timeout issues, commenting out tests reduces coverage significantly. This appears to be debugging code that was accidentally committed rather than a proper fix for the flaky test.