Update Acoustics Module#447
Conversation
…y vector weighting for calculating band-averaged SPLs
|
@jmcvey3 there is a test failure on python 3.10. Any ideas on a fix there? I don't know why python 3.10 would have a different numerical result for one calculation? The other test failures don't seem to be caused by any of your changes. https://github.com/MHKiT-Software/MHKiT-Python/actions/runs/27647812694/job/81902073822#step:8:419 |
Thanks for looking so quick. Looks like a machine precision error, since it's saying 9.94873047e-06 < 1e-7. I'll set the relative tolerance to 1e-6. |
…leanup deprecation warning strings
| method_name : str | ||
| The validated method name in lowercase. | ||
| method_arg : float, int, or None | ||
| The argument associated with the method, if applicableotherwise, None. |
|
Thanks Andrew for hopping on this! We're going to do a data comparison from work up in Igiugig with the UW research group soonish, so I'd like to wait to merge until we've started that. |
Sounds good, happy to wait. We are planning a 1.1 release by the end of this quarter (Jun 30). Do you think this your planned work for this work will fall outside of that timeline? That is fine IMO, just wondering if we should try to include this in the next release and if we need to adjust the release timeline accordingly. |
I'll try to have it done by then, yes, because I'd like to have this in the next release. |
|
@simmsa Is this notebook error a new error from pandas 3.0? |
Enhancements:
Bugfixes
The jupyter notebook has been updated with these changes as well.