Updated ADCP examples #448
Open
browniea wants to merge 12 commits into
Open
Conversation
Closed
Contributor
Author
|
#432 (comment) "Aiming to have this PR done by 6/22 so that we have time to review/merge before getting the develop branch into main before 7/1" |
Contributor
Author
|
MHKiT matlab had a function dolfyn_plot. For now I'm opting to add the plots without rewriting a plotting script. I find this to be more transparent and easier to troubleshoot for the user but, I'm open to feedback. |
Contributor
Author
|
I need to updo the changes to examples/ADCP_Delft3D_TRTS_example.ipynb. I was just testing the USGS code and accidentally pushed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding visualizations to match the MHKiT_MATLAB ADCP example and addressing several issues:
Qhull Error #444
D3D coordinate systems #442