Fix deprecated scipy.ndimage import paths#129
Open
evertdeman wants to merge 3 commits intoMIC-DKFZ:masterfrom
Open
Fix deprecated scipy.ndimage import paths#129evertdeman wants to merge 3 commits intoMIC-DKFZ:masterfrom
evertdeman wants to merge 3 commits intoMIC-DKFZ:masterfrom
Conversation
Author
|
Ah, I see there is another PR open for this: #108 Any reason we should not merge this? |
|
@FabianIsensee any way to merge this? This is a trivial change. Maybe you never noticed the warnings because DeprecationWarnings are suppressed by default and you typically only see them via test suites runners which "unsuppress" them (pytest does this). I saw some references to https://grugbrain.dev/ in the nnUNet source code, if I may quote it to try to convince you:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am getting some warning like
this should fix that