Remove ProQuest submission field from thesis forms

[jazairi]

Why these changes are being introduced:

The Libraries are suspending the pilot with ProQuest, and the thesis forms should be updated.

Relevant ticket(s):

• ETD-658

How this addresses that need:

This removes the ProQuest fieldset from the new and edit forms. It also removes the author_fields partial, which includes only this fieldset.

Note that this does not remove any additional ProQuest export functionality, as specifically requested by stakeholders.

Side effects of this change:

Because no functionality outside of the thesis form has been changed, thesis processors can still run ProQuest exports. There is no apparent risk to this, and we can fully remove the feature if stakeholders decide to do so.

Developer

• All new ENV is documented in README
• All new ENV has been added to Heroku Pipeline, Staging and Prod
• ANDI or Wave has been run in accordance to
  our guide and
  all issues introduced by these changes have been resolved or opened as new
  issues (link to those issues in the Pull Request details above)
• Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

• The commit message is clear and follows our guidelines
  (not just this pull request message)
• There are appropriate tests covering any new functionality
• The documentation has been updated or is unnecessary
• The changes have been verified
• New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

[coveralls]

coverage: 98.313%. remained the same
when pulling 9f627a4 on etd-658-remove-pq-form
into d789473 on main.

[JPrevost]

This looks good. I forgot how complex this feature is under the hood and it took me a while to confirm the Export would work as I expected with the null values we'll have (the tests had coverage for it which was great, but I wanted to see it working locally (and it worked differently than I expected but is doing the correct thing so I'm glad I checked). After further reflection, it makes sense it works the way it does as Users aren't actually required to login and update their metadata so null has always been a supported status for this.

Please tag Mikki in the ETD channel and Jira ticket to review once this merges but before it is moved to production. Production launch for this will be whenever the ETD says to launch it (not sure if they want to update some supporting instructions first or if they'll want this live once they confirm it).

[JPrevost]

Also, I noticed we don't update the strong params (https://github.com/MITLibraries/thing/blob/main/app/controllers/thesis_controller.rb#L193) as part of this but I think because the feature is remaining on the admin-side it makes sense to leave it as-is. I'm saying that here in case you look at it and disagree and think it can come out now. We seem to use the same params for multiple form updates which seems maybe not the best idea but is outside the scope of this changeset.