feat(tooling): add Makefile and extract check_ids script#11
Merged
Conversation
- add Makefile with validate, check-ids, check, build-indexes targets - extract duplicate ID check into scripts/check_ids.py for reuse - simplify CI workflows to call scripts/check_ids.py instead of inline heredoc - remove duplicate source files: bis-statistics.json and sectors/education/arwu.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefilewith four targets:validate,check-ids,check,build-indexesfor local development conveniencescripts/check_ids.pyto avoid inline heredoc in CI workflowsvalidate-sources.ymlandupdate-indexes.ymlto callscripts/check_ids.pydirectlyfirstdata/sources/academic/economics/bis-statistics.json(duplicate ofinternational/economics/bis.json)firstdata/sources/sectors/education/arwu.json(duplicate ofsectors/P-education/arwu.json, also had invalid schema format)Test plan
make checkpasses: all 134 source files valid, all IDs uniquemake build-indexesruns successfully