-
Notifications
You must be signed in to change notification settings - Fork 40
Create a thin film below grounded ice for meshes with ice-shelf cavities #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The ice draft is determined by flotation in floating regions but is equal to the bed elevation in grounded regions. We also include `sea_level` (currently zero) in the calculation of the ice draft.
Expansion-based smoothing produces bed_elevation > 0.This commit 124942c will be used to cull these cells until another solution is found. |
|
@xylar Here's the branch I've been working from, with your commit added. Remove the last commit to reproduce the smoothing issue (I used expand_factor = 2). |
TestingI used the following command: with |
|
This branch should be rebased onto |
Work-in-progress: changes needed to support a thin mesh below grounded ice
Checklist
api.rst) has any new or modified class, method and/or functions listedE3SM-Projectsubmodule has been updated with relevant E3SM changesMALI-Devsubmodule has been updated with relevant MALI changesTestingin this PR) any testing that was used to verify the changes