updated buffer size#128
Open
deepakcloudsoffical wants to merge 3 commits into
Open
Conversation
Author
|
updated buffer size 256mb |
Owner
|
Since it's an in memory buffer, increasing it over 128mb runs at risk of OOM crashes, without android heap being explicitly set to large which I want to avoid. Another approach is to have disk cache, which should allow us better flexibility. I'll take a look at the feasibility of the later, but currently not inclined towards merging this. @deepakcloudsoffical |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated buffer size
512mb
1024mb