Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 28 additions & 29 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,51 +1,50 @@
<!--
Thank you for contributing to the MariaDB Server repository!

You can help us review your changes faster by filling in this template <3

If you have any questions related to MariaDB or you just want to hang out and meet other community members, please join us on https://mariadb.zulipchat.com/ .
Thank you for contributing to the MariaDB Server repository!
You can help us review your changes faster by completing this template. :orange_heart:
If you have any questions related to MariaDB or only to meet other community members, please join us on https://mariadb.zulipchat.com/.
-->

<!--
If you've already identified a https://jira.mariadb.org/ issue that seems to track this bug/feature, please add its number below.
If you've already identified a https://jira.mariadb.org/ issue that tracks this bug/feature, please add its number below.
-->
- [x] *The Jira issue number for this PR is: MDEV-______*
- [ ] *The Jira issue number for this PR is: [MDEV-_____](https://jira.mariadb.org/browse/MDEV-_____)*

<!--
An amazing description should answer some questions like:
1. What problem is the patch trying to solve?
2. If some output changed that is not visible in a test case, what was it looking like before the change and how it's looking with this patch applied?
3. Do you think this patch might introduce side-effects in other parts of the server?
-->
## Description
TODO: fill description here
<!--
An excellent description should answer some questions like:
1. What problem is the patch trying to solve?
2. If some output changed that is not visible in a test case, what was it looking like before the change, and how does it look with this patch applied?
3. Do you think this patch might introduce side effects in other parts of the server?
-->

## Release Notes
TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.

## How can this PR be tested?
<!--
Include any changed system variables, status variables or behaviour.
List any https://mariadb.com/kb/ pages that need changing.
-->

## How to test this PR?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Active Voice > Passive Voice

TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on ["Writing good test cases"](https://mariadb.org/get-involved/getting-started-for-developers/writing-good-test-cases-mariadb-server).
<!--
In many cases, this will be as simple as modifying one `.test` and one `.result` file in the `mysql-test/` subdirectory.
Without automated tests, future regressions in the expected behavior can't be automatically detected and verified.
Consult the documentation on ["Writing good test cases"](https://mariadb.org/get-involved/getting-started-for-developers/writing-good-test-cases-mariadb-server).
In many cases, this will be as simple as modifying one `.test` and one `.result` file in the `mysql-test/` subdirectory.
Without automated tests, future regressions in the expected behavior can't be automatically detected and verified.
-->
If the changes are not amenable to automated testing, please explain why and carefully describe how to test manually.

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

## Basing the PR on the correct MariaDB version
<!--
Tick one of the following boxes [x] to help us understand if the base branch for the PR is correct.
Tick (`[x]`) one of the following boxes to help us understand if the base branch for the PR is correct.
-->
## Basing the PR against the correct MariaDB version
- [ ] *This is a new feature or a refactoring, and the PR is based against the `main` branch.*
- [ ] *This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.*
- [ ] *This is a new feature or a refactoring, and the PR is based on the `main` branch.*
- [ ] *This is a bug fix, and the PR is based on the earliest maintained branch in which the bug can be reproduced.*

## PR Quality Check
<!--
All code merged into the MariaDB codebase must meet a quality standard and coding style.
Maintainers are happy to point out inconsistencies but in order to speed up the review and merge process we ask you to check the CODING standards.
Maintainers are happy to point out inconsistencies, but to speed up the review and merge process, we ask you to verify the Coding Standards.
-->
## PR quality check
- [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/-/CODING_STANDARDS.md) file and my PR conforms to this where appropriate.
- [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.
- [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/-/CODING_STANDARDS.md) file, and my PR conforms to this where appropriate.
- [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, the PR UI doesn’t strip the trailing ␊.
It’s standard for files, but looks odd in a multiline textbox.

Loading