-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update pull_request_template.md
#4209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,50 @@ | ||
| <!-- | ||
| Thank you for contributing to the MariaDB Server repository! | ||
|
|
||
| You can help us review your changes faster by filling in this template <3 | ||
|
|
||
| If you have any questions related to MariaDB or you just want to hang out and meet other community members, please join us on https://mariadb.zulipchat.com/ . | ||
| Thank you for contributing to the MariaDB Server repository! | ||
| You can help us review your changes faster by completing this template. :orange_heart: | ||
| If you have any questions related to MariaDB or only to meet other community members, please join us on https://mariadb.zulipchat.com/. | ||
| --> | ||
|
|
||
| <!-- | ||
| If you've already identified a https://jira.mariadb.org/ issue that seems to track this bug/feature, please add its number below. | ||
| If you've already identified a https://jira.mariadb.org/ issue that tracks this bug/feature, please add its number below. | ||
| --> | ||
| - [x] *The Jira issue number for this PR is: MDEV-______* | ||
| - [ ] *The Jira issue number for this PR is: [MDEV-_____](https://jira.mariadb.org/browse/MDEV-_____)* | ||
|
|
||
| <!-- | ||
| An amazing description should answer some questions like: | ||
| 1. What problem is the patch trying to solve? | ||
| 2. If some output changed that is not visible in a test case, what was it looking like before the change and how it's looking with this patch applied? | ||
| 3. Do you think this patch might introduce side-effects in other parts of the server? | ||
| --> | ||
| ## Description | ||
| TODO: fill description here | ||
| <!-- | ||
| An excellent description should answer some questions like: | ||
| 1. What problem is the patch trying to solve? | ||
| 2. If some output changed that is not visible in a test case, what was it looking like before the change, and how does it look with this patch applied? | ||
| 3. Do you think this patch might introduce side effects in other parts of the server? | ||
| --> | ||
|
|
||
| ## Release Notes | ||
| TODO: What should the release notes say about this change? | ||
| Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing. | ||
|
|
||
| ## How can this PR be tested? | ||
| <!-- | ||
| Include any changed system variables, status variables or behaviour. | ||
| List any https://mariadb.com/kb/ pages that need changing. | ||
| --> | ||
|
|
||
| ## How to test this PR? | ||
| TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended. | ||
| Consult the documentation on ["Writing good test cases"](https://mariadb.org/get-involved/getting-started-for-developers/writing-good-test-cases-mariadb-server). | ||
| <!-- | ||
| In many cases, this will be as simple as modifying one `.test` and one `.result` file in the `mysql-test/` subdirectory. | ||
| Without automated tests, future regressions in the expected behavior can't be automatically detected and verified. | ||
| Consult the documentation on ["Writing good test cases"](https://mariadb.org/get-involved/getting-started-for-developers/writing-good-test-cases-mariadb-server). | ||
| In many cases, this will be as simple as modifying one `.test` and one `.result` file in the `mysql-test/` subdirectory. | ||
| Without automated tests, future regressions in the expected behavior can't be automatically detected and verified. | ||
| --> | ||
| If the changes are not amenable to automated testing, please explain why and carefully describe how to test manually. | ||
|
|
||
| If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually. | ||
|
|
||
| ## Basing the PR on the correct MariaDB version | ||
| <!-- | ||
| Tick one of the following boxes [x] to help us understand if the base branch for the PR is correct. | ||
| Tick (`[x]`) one of the following boxes to help us understand if the base branch for the PR is correct. | ||
| --> | ||
| ## Basing the PR against the correct MariaDB version | ||
| - [ ] *This is a new feature or a refactoring, and the PR is based against the `main` branch.* | ||
| - [ ] *This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.* | ||
| - [ ] *This is a new feature or a refactoring, and the PR is based on the `main` branch.* | ||
| - [ ] *This is a bug fix, and the PR is based on the earliest maintained branch in which the bug can be reproduced.* | ||
|
|
||
| ## PR Quality Check | ||
| <!-- | ||
| All code merged into the MariaDB codebase must meet a quality standard and coding style. | ||
| Maintainers are happy to point out inconsistencies but in order to speed up the review and merge process we ask you to check the CODING standards. | ||
| Maintainers are happy to point out inconsistencies, but to speed up the review and merge process, we ask you to verify the Coding Standards. | ||
| --> | ||
| ## PR quality check | ||
| - [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/-/CODING_STANDARDS.md) file and my PR conforms to this where appropriate. | ||
| - [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves. | ||
| - [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/-/CODING_STANDARDS.md) file, and my PR conforms to this where appropriate. | ||
| - [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Somehow, the PR UI doesn’t strip the trailing ␊. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Active Voice > Passive Voice