MDEV-31669: use XXH3 as a digest instead of md5#4573
MDEV-31669: use XXH3 as a digest instead of md5#4573MohamedM216 wants to merge 1 commit intoMariaDB:mainfrom
Conversation
gkodinov
left a comment
There was a problem hiding this comment.
This is a preliminary review. Right now there's no strong opposition against removing MD5 from this. But the choice of a replacement hash function is yet to be determined. I can see the logic in Sergei's argument that using a crypto hash for a non-crypto purpose is kind of a mismatch. But I will leave that discussion for the final review now.
First of all: please make sure the change compiles and runs all buildbot test in a satisfactory way.
899f3b3 to
3e7b460
Compare
gkodinov
left a comment
There was a problem hiding this comment.
Please switch this to XXH3, as suggested by Sergei. I will then do a full review of the result once this is done.
3e7b460 to
241cb0c
Compare
241cb0c to
ea765b3
Compare
|
Apologies, I accidentally closed this PR. |
gkodinov
left a comment
There was a problem hiding this comment.
Thanks for switching to XXhash.
OK to push from me, given that you add a commit message to the commit that follows CODING_STANDARDS.md.
Please wait for the final review.
- Following MySQL implementation as mentioned in the PR description - XXH is significantly faster than both MD5 and SHA-256 - Here we use the standard 64-bit XXH3 - Reduce DIGEST_HASH_SIZE to 8 bytes - DIGEST columns are changed from VARCHAR(32) to VARCHAR(16)
ea765b3 to
233436e
Compare
|
Hi @gkodinov , I've updated the commit message. Thanks! |
Jira Issue number for this PR: MDEV-31669
I followed mysql implementation as suggested in jira.