MDEV-36025: backup taken from a replica with optimistic parallel replication fails to restore most of the time #4888
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| CALL mtr.add_suppression("Found 1 prepared XA transactions"); | ||
| RESET MASTER; | ||
| CREATE TABLE t1 (a INT) ENGINE=INNODB; | ||
| XA START 'test1'; | ||
| INSERT t1 VALUES (10); | ||
| XA END 'test1'; | ||
| XA PREPARE 'test1'; | ||
| XA RECOVER; | ||
| formatID gtrid_length bqual_length data | ||
| 1 5 0 test1 | ||
| # xtrabackup backup | ||
| XA ROLLBACK 'test1'; | ||
| # xtrabackup prepare and rollback prepared XA | ||
| # shutdown server | ||
| # remove datadir | ||
| # xtrabackup move back | ||
| # restart | ||
| XA RECOVER; | ||
| formatID gtrid_length bqual_length data | ||
| 1 5 0 test1 | ||
| # xtrabackup prepare and DO NOT rollback prepared XA | ||
| # shutdown server | ||
| # remove datadir | ||
| # xtrabackup move back | ||
| # restart | ||
| XA RECOVER; | ||
| formatID gtrid_length bqual_length data | ||
| 1 5 0 test1 | ||
| XA ROLLBACK 'test1'; | ||
| # xtrabackup prepare for export and rollback prepared XA (should fail) | ||
| # The above command should fail with error about incompatible options | ||
| # xtrabackup prepare for export and DO NOT rollback prepared XA | ||
| # shutdown server | ||
| # remove datadir | ||
| # xtrabackup move back | ||
| # restart | ||
| XA RECOVER; | ||
| formatID gtrid_length bqual_length data | ||
| 1 5 0 test1 | ||
| XA ROLLBACK 'test1'; | ||
| DROP TABLE t1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| # | ||
| # Optionally rollback prepared XA when backup is prepared | ||
| # | ||
| --source include/have_innodb.inc | ||
| --source include/have_binlog_format_mixed.inc | ||
|
|
||
| CALL mtr.add_suppression("Found 1 prepared XA transactions"); | ||
|
|
||
| RESET MASTER; | ||
|
|
||
| let targetdir1=$MYSQLTEST_VARDIR/tmp/backup1; | ||
| let targetdir2=$MYSQLTEST_VARDIR/tmp/backup2; | ||
| let targetdir3=$MYSQLTEST_VARDIR/tmp/backup3; | ||
| let targetdir4=$MYSQLTEST_VARDIR/tmp/backup4; | ||
|
|
||
| CREATE TABLE t1 (a INT) ENGINE=INNODB; | ||
| XA START 'test1'; | ||
| INSERT t1 VALUES (10); | ||
| XA END 'test1'; | ||
| XA PREPARE 'test1'; | ||
| XA RECOVER; | ||
|
|
||
| --echo # xtrabackup backup | ||
| --disable_result_log | ||
| exec $XTRABACKUP --defaults-file=$MYSQLTEST_VARDIR/my.cnf --backup --target-dir=$targetdir1; | ||
| --enable_result_log | ||
|
|
||
| perl; | ||
| use lib "lib"; | ||
| use My::Handles { suppress_init_messages => 1 }; | ||
| use My::File::Path; | ||
| copytree($ENV{'targetdir1'}, $ENV{'targetdir2'}); | ||
| copytree($ENV{'targetdir1'}, $ENV{'targetdir3'}); | ||
| copytree($ENV{'targetdir1'}, $ENV{'targetdir4'}); | ||
| EOF | ||
|
|
||
| XA ROLLBACK 'test1'; | ||
|
|
||
| --echo # xtrabackup prepare and rollback prepared XA | ||
| --disable_result_log | ||
| exec $XTRABACKUP --prepare --rollback_xa --target-dir=$targetdir1; | ||
| --let $targetdir = $targetdir1 | ||
| --source include/restart_and_restore.inc | ||
| --enable_result_log | ||
| XA RECOVER; | ||
|
|
||
| --echo # xtrabackup prepare and DO NOT rollback prepared XA | ||
| --disable_result_log | ||
| exec $XTRABACKUP --prepare --target-dir=$targetdir2; | ||
| --let $targetdir = $targetdir2 | ||
| --source include/restart_and_restore.inc | ||
| --enable_result_log | ||
| XA RECOVER; | ||
| XA ROLLBACK 'test1'; | ||
|
|
||
| --echo # xtrabackup prepare for export and rollback prepared XA (should fail) | ||
| --disable_result_log | ||
| --error 1 | ||
| exec $XTRABACKUP --prepare --rollback_xa --export --target-dir=$targetdir3; | ||
| --echo # The above command should fail with error about incompatible options | ||
|
|
||
| --echo # xtrabackup prepare for export and DO NOT rollback prepared XA | ||
| --disable_result_log | ||
| exec $XTRABACKUP --prepare --export --target-dir=$targetdir4 --skip-rollback-xa; | ||
| --let $targetdir = $targetdir4 | ||
| --source include/restart_and_restore.inc | ||
| --enable_result_log | ||
| XA RECOVER; | ||
| XA ROLLBACK 'test1'; | ||
|
|
||
| DROP TABLE t1; | ||
| rmdir $targetdir1; | ||
| rmdir $targetdir2; | ||
| rmdir $targetdir3; | ||
| rmdir $targetdir4; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| call mtr.add_suppression("Can't init tc log"); | ||
| call mtr.add_suppression("Found .* prepared transactions!"); | ||
| call mtr.add_suppression("Aborting"); | ||
| CREATE TABLE t1 (a INT) ENGINE=INNODB; | ||
| SET GLOBAL innodb_flush_log_at_trx_commit=1; | ||
| INSERT INTO t1 VALUES (0); | ||
| FLUSH TABLES; | ||
| connect con1,localhost,root,,; | ||
| SET debug_sync='ha_commit_trans_after_prepare WAIT_FOR go'; | ||
| INSERT INTO t1 VALUES (1); | ||
| connect con2,localhost,root,,; | ||
| SET debug_sync='ha_commit_trans_after_prepare WAIT_FOR go'; | ||
| INSERT INTO t1 VALUES (2); | ||
| connect con3,localhost,root,,; | ||
| SET debug_sync='ha_commit_trans_after_prepare WAIT_FOR go'; | ||
| INSERT INTO t1 VALUES (3); | ||
| connect con4,localhost,root,,; | ||
| SET debug_sync='ha_commit_trans_after_prepare WAIT_FOR go'; | ||
| INSERT INTO t1 VALUES (4); | ||
| connect con5,localhost,root,,; | ||
| SET debug_sync='ha_commit_trans_after_prepare WAIT_FOR go'; | ||
| INSERT INTO t1 VALUES (5); | ||
| connection default; | ||
| # Kill the server | ||
| FOUND 1 /Found .* prepared transactions!/ in mysqld.1.err | ||
| # restart | ||
| SELECT * FROM t1; | ||
| a | ||
| 0 | ||
| DROP TABLE t1; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think it is acceptable to change the default behaviour in stable release series. The need to change a large number of existing tests in a stable release series should be a warning sign to any reviewer.
Furthermore, I don’t think it is acceptable to break incremental backup by default, in any release.