MDEV-39721: SIGSEGV in check_word|(extract_date_time|extract_oracle_date_time)#4917
Open
raghunandanbhat wants to merge 1 commit into12.3from
Open
MDEV-39721: SIGSEGV in check_word|(extract_date_time|extract_oracle_date_time)#4917raghunandanbhat wants to merge 1 commit into12.3from
check_word|(extract_date_time|extract_oracle_date_time)#4917raghunandanbhat wants to merge 1 commit into12.3from
Conversation
…cle_date_time`) Problem: Date and time functions - `STR_TO_DATE` and `TO_DATE` (in Oracle mode) both use `check_word` to check if a string token matches a valid locale-specific day or month name. Server crashed because of an un-initialized typelib member(`type_lengths`) for date locales which are not present in `Oracle_date_locale` (e.g: `ar_DZ`). Fix: Initialize `type_lengths` for all supported locales by iterating over `my_locales` array instead of `Oracle_date_locale` during server startup.
raghunandanbhat
force-pushed
the
12.3-mdev-39721
branch
from
154368a to
1dbac02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes MDEV-39721
Problem:
Date and time functions -
STR_TO_DATEandTO_DATE(in Oracle mode) usecheck_wordto check if a string token matches a valid locale-specific day or month name. Server crashed because of an un-initialized typelib member(type_lengths) for date locales which are not present inOracle_date_locale(e.g:ar_DZ).Fix:
Initialize
type_lengthsfor all supported locales by iterating overmy_localesarray instead ofOracle_date_localeduring server startup.