Skip to content

orchestratord: Retry in balancer controller#35797

Closed
def- wants to merge 1 commit intoMaterializeInc:mainfrom
def-:pr-balancer-retry
Closed

orchestratord: Retry in balancer controller#35797
def- wants to merge 1 commit intoMaterializeInc:mainfrom
def-:pr-balancer-retry

Conversation

@def-
Copy link
Copy Markdown
Contributor

@def- def- commented Mar 31, 2026 •
edited
Loading

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def- def- force-pushed the pr-balancer-retry branch from a3e290d to 3958d26 Compare March 31, 2026 09:54
@def- def- force-pushed the pr-balancer-retry branch from 3958d26 to 32273b4 Compare March 31, 2026 10:06
@def- def- requested a review from doy-materialize March 31, 2026 10:06
@def-
Copy link
Copy Markdown
Contributor Author

def- commented Mar 31, 2026

@doy-materialize Does this make sense to you?

@def- def- marked this pull request as ready for review March 31, 2026 10:12
@def- def- requested a review from a team as a code owner March 31, 2026 10:12
doy-materialize
doy-materialize approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@doy-materialize doy-materialize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yeah, this does seem plausible! worth a shot

@def-
Copy link
Copy Markdown
Contributor Author

def- commented Mar 31, 2026

Closing in favor of #35806

@def- def- closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doy-materialize doy-materialize doy-materialize approved these changes

@alex-hunt-materialize alex-hunt-materialize Awaiting requested review from alex-hunt-materialize

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@def- @doy-materialize