Skip to content

python: Remove dead code#35798

Merged
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-dead-tests
Mar 31, 2026
Merged

python: Remove dead code#35798
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-dead-tests

Conversation

@def-
Copy link
Copy Markdown
Contributor

@def- def- commented Mar 31, 2026

No description provided.

@def- def- requested a review from bosconi March 31, 2026 11:40
@def- def- requested review from a team as code owners March 31, 2026 11:40
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def- def- merged commit c8a3435 into MaterializeInc:main Mar 31, 2026
109 checks passed
@def- def- deleted the pr-dead-tests branch March 31, 2026 13:51
@def- def- mentioned this pull request Mar 31, 2026
Merged
def- added a commit that referenced this pull request Mar 31, 2026
@def-
zippy: Fix pydoc (#35805)
43f6816 
Seen failing in
https://buildkite.com/materialize/test/builds/119646#019d442a-5955-4bf7-9457-36c9aaca7965

Follow-up to #35798

Test run: https://buildkite.com/materialize/test/builds/119648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-hunt-materialize alex-hunt-materialize alex-hunt-materialize approved these changes

@bosconi bosconi Awaiting requested review from bosconi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@def- @alex-hunt-materialize