adapter: Add TLA+ formal verification of timestamp selection#35803
Draft
antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
Draft
adapter: Add TLA+ formal verification of timestamp selection#35803antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
573caf3 to
193849c
Compare
Add a TLA+ specification that models the constraint solver in `determine_timestamp_via_constraints` as a pure function over a bounded timestamp domain. The spec covers constraint generation for all three isolation levels (Serializable, StrictSerializable, StrongSessionSerializable) and all QueryWhen variants. TLC exhaustively verifies 750,000 input combinations checking: - Result respects all lower/upper bounds - Real-time ordering (result >= oracle_read_ts when oracle is a constraint) - Completeness (non-empty interval => success) - Soundness (success => non-empty interval) - FreshestAvailable picks the largest valid timestamp - StalestValid picks the smallest valid timestamp Packaged as an mzcompose test: `bin/mzcompose --find tla run timestamp-selection` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
193849c to
e0d74f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
determine_timestamp_via_constraintsover a bounded timestamp domain (0..4)QueryWhenvariantsTest plan
bin/mzcompose --find tla run timestamp-selectionpasses locally (750k states, 6s, all 7 properties verified)TODO: Integrate the check in
ci/test/pipeline.template.yml🤖 Generated with Claude Code