Skip to content

Mysql CDC test fix: SET TRANSACTION_ISOLATION TO SERIALIZABLE#35811

Merged
patrickwwbutler merged 1 commit intoMaterializeInc:mainfrom
patrickwwbutler:patrick/mysql-vsf-fix
Apr 1, 2026
Merged

Mysql CDC test fix: SET TRANSACTION_ISOLATION TO SERIALIZABLE#35811
patrickwwbutler merged 1 commit intoMaterializeInc:mainfrom
patrickwwbutler:patrick/mysql-vsf-fix

Conversation

@patrickwwbutler
Copy link
Copy Markdown
Contributor

Fixes https://github.com/MaterializeInc/database-issues/issues/11264

This test was flaky because sometime the select * from t1 query would run after the mysql db was finished restoring, and so no more transactions occur, and thus the progress never ticks forward, and our query is forever waiting for the next transaction so it can be sure the current one is complete.

Running SET TRANSACTION_ISOLATION TO SERIALIZABLE fixes this by not waiting for the next transaction.

@patrickwwbutler patrickwwbutler requested a review from a team March 31, 2026 18:45
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

Copy link
Copy Markdown
Contributor

@martykulma martykulma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦈

@patrickwwbutler patrickwwbutler merged commit 0b2e40d into MaterializeInc:main Apr 1, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants