Skip to content

cla: allow github-actions[bot] to bypass CLA check#35813

Merged
bosconi merged 1 commit intomainfrom
fix/cla-allow-github-actions-bot
Mar 31, 2026
Merged

cla: allow github-actions[bot] to bypass CLA check#35813
bosconi merged 1 commit intomainfrom
fix/cla-allow-github-actions-bot

Conversation

@bosconi
Copy link
Copy Markdown
Member

@bosconi bosconi commented Mar 31, 2026

Summary

Test plan

Generated with Claude Code

Automated PRs created by GitHub Actions workflows (e.g.
update-generated-docs) are authored by github-actions[bot], which
is not a real contributor and cannot sign a CLA.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bosconi bosconi requested a review from a team as a code owner March 31, 2026 20:55
@github-actions
Copy link
Copy Markdown

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@bosconi
Copy link
Copy Markdown
Member Author

bosconi commented Mar 31, 2026

@def- is adding github-actions[bot] to the CLA allowlist the right approach?

The alternative would be to change update-generated-docs.yml to submit the PR as materialize-bot?

Copy link
Copy Markdown
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@def- is adding github-actions[bot] to the CLA allowlist the right approach?

Seems ok to me

@bosconi bosconi merged commit 1de477a into main Mar 31, 2026
8 checks passed
@bosconi bosconi deleted the fix/cla-allow-github-actions-bot branch March 31, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants