console: simplify connect modal instructions text#37024
Open
maheshwarip wants to merge 1 commit into
Open
Conversation
The OIDC connect modal's instructions linked specifically to the GCP installation guide, which was misleading since the modal is shown for all self-managed deployments regardless of cloud provider. Simplify the text to just the relevant instruction, dropping the provider-specific link. https://claude.ai/code/session_016zS64CWRsmpjjA2JvzsUbJ
maheshwarip
force-pushed
the
claude/slack-session-ioohiw
branch
from
04d9f59 to
2ecd836
Compare
maheshwarip
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the console's "Connect To Materialize" modal (
OidcConnectModal), the instructions text linked specifically to the GCP installation guide:This modal is shown for all self-managed deployments regardless of cloud provider, so the provider-specific link was misleading for users on AWS, Azure, or local kind/minikube. This was flagged in Slack.
Changes
Simplify the instructions text to just the relevant instruction, dropping the provider-specific link (and the now-unused
Code/TextLinkimports):Context
Slack thread: https://materializeinc.slack.com/archives/CU7ELJ6E9/p1781299955523019?thread_ts=1781299703.506719&cid=CU7ELJ6E9