Skip to content

<fix>[plugin-premium]: GPU/VM page keeps loading when shutting down or encountering errors in Zaku cluster. #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zstack-robot-2 wants to merge 1 commit into
base: 5.5.0
Choose a base branch
from
Open

<fix>[plugin-premium]: GPU/VM page keeps loading when shutting down or encountering errors in Zaku cluster. #3126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions header/src/main/java/org/zstack/header/zql/BeforeCallZWatchExtensionPoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package org.zstack.header.zql;

import java.util.List;

/**
* BeforeZQLReturnWithExtensionPoint is an extension point that allows plugins
* to perform custom operations before calling zwatch.
*/
public interface BeforeCallZWatchExtensionPoint {
Comment on lines +5 to +9
Copy link

@coderabbitai coderabbitai bot Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

修正 Javadoc 中的接口名称错误。

第 6 行 Javadoc 中的接口名称为 BeforeZQLReturnWithExtensionPoint，但实际接口名称是 BeforeCallZWatchExtensionPoint。这会造成文档与代码不一致，影响代码的可维护性。

🔎 修复建议 
 /**
- * BeforeZQLReturnWithExtensionPoint is an extension point that allows plugins
+ * BeforeCallZWatchExtensionPoint is an extension point that allows plugins
  * to perform custom operations before calling zwatch.
  */
 public interface BeforeCallZWatchExtensionPoint {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
/**
* BeforeZQLReturnWithExtensionPoint is an extension point that allows plugins
* to perform custom operations before calling zwatch.
*/
public interface BeforeCallZWatchExtensionPoint {
/**
* BeforeCallZWatchExtensionPoint is an extension point that allows plugins
* to perform custom operations before calling zwatch.
*/
public interface BeforeCallZWatchExtensionPoint {
🤖 Prompt for AI Agents 
In
header/src/main/java/org/zstack/header/zql/BeforeCallZWatchExtensionPoint.java
around lines 5 to 9, the Javadoc incorrectly names the interface as
BeforeZQLReturnWithExtensionPoint; update the Javadoc to use the correct
interface name BeforeCallZWatchExtensionPoint and adjust the descriptive
sentence to match the actual interface purpose (e.g.,
"BeforeCallZWatchExtensionPoint is an extension point that allows plugins to
perform custom operations before calling zwatch.").

/**
* Check if this extension supports the given VO class
* @param voClass the VO class to check
* @return true if this extension supports the VO class, false otherwise
*/
boolean supports(Class<?> voClass);

/**
* Perform custom operations before calling ZWatch, for example: health-check
* @param voClass the VO class type
* @param uuids the list of resource UUIDs to process
*/
void beforeCallZWatch(Class<?> voClass, List<String> uuids);
}