<fix>[keyprovider]: Refine rekey validation and skip reporting#3623
<fix>[keyprovider]: Refine rekey validation and skip reporting#3623zstack-robot-2 wants to merge 1 commit intofeature-zsv-5.0.0-vm-support-vtpm-and-secucebootfrom
Conversation
Resolves: ZSV-11505 Change-Id: I6f756f7362636c7878676c786d6371746574746f
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
功能概览此次变更为密钥提供商重新生成(rekey)操作添加了新的数据模型支持。新增 变更详情
代码审查工作量评估🎯 2 (Simple) | ⏱️ ~12 分钟 诗歌
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Comment from yaohua.wu: Review: MR !9482 (zstack SDK) — ZSV-11505关联 MR: premium !13352(核心业务逻辑变更),完整 review 已发布在 premium MR。 本 MR 仅包含 SDK 侧自动生成的类和 SourceClassMap 映射,变更简单明确。 🟢 Suggestion1. [RekeyKeyProviderRefsResult.java] public java.util.List skippedResources;缺少泛型参数,应为 2. [RekeySkippedResource.java] 字段 visibility 为 SDK 类的 public 字段 + getter/setter 的风格虽然是项目既有模式(auto-generated),但如果后续有机会改进生成器,建议字段设为 private。 Verdict: APPROVEDSDK 变更与 premium 侧的 🤖 Robot Reviewer |
Resolves: ZSV-11505
Change-Id: I6f756f7362636c7878676c786d6371746574746f
sync from gitlab !9482