Skip to content

[host]: SystemTagCreator ignoreIfExisting to prevent duplicate tags #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatheMatrix wants to merge 2 commits into
base: 5.5.22
Choose a base branch
from
Open

[host]: SystemTagCreator ignoreIfExisting to prevent duplicate tags #3950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f516edd
<fix>[host]: SystemTagCreator ignoreIfExisting to prevent duplicate r…
May 19, 2026
e17a62e
<fix>[conf]: update detach timeout error regex to match dynamic timeo…
May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compute/src/main/java/org/zstack/compute/host/HostBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,6 +1099,7 @@ private void updateHostConnectedTime(HostStatus hostStatus) {
creator.setTagByTokens(Collections.singletonMap(token, connectedTime));
creator.inherent = false;
creator.recreate = false;
creator.ignoreIfExisting = true;
creator.create();
return;
}
Expand Down
2 changes: 1 addition & 1 deletion conf/errorElaborations/Elaboration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@
"category": "PS",
"code": "1000",
"method": "distance",
"regex": "failed to detach data volume[uuid:%s, installPath:%s] from vm[uuid:%s, name:%s] on kvm host[uuid:%s, ip:%s], because unable to detach the volume from the vm;it's still attached after 5 seconds",
"regex": "failed to detach data volume[uuid:%s, installPath:%s] from vm[uuid:%s, name:%s] on kvm host[uuid:%s, ip:%s], because unable to detach the volume from the vm;it's still attached after \\d+ seconds",
"message_cn": "由于云主机操作系统限制可能会导致卸载云盘失败，请尝试对云主机关机后再次卸载。",
"message_en": "Detaching volume may fail due to limitations of the VM operating system. Please try again after VM shutdown."
},
Expand Down