Skip to content

ci: skip external links in broken link check#11548

Open
jd wants to merge 1 commit into
mainfrom
devs/jd/broken-links/skip-external-links-broken-link-check--6ac9560a
Open

ci: skip external links in broken link check#11548
jd wants to merge 1 commit into
mainfrom
devs/jd/broken-links/skip-external-links-broken-link-check--6ac9560a

Conversation

@jd
Copy link
Copy Markdown
Member

@jd jd commented May 18, 2026

External link checks cause flaky CI failures unrelated to PR changes.
Only check internal links which are deterministic and catch real issues.

External link checks cause flaky CI failures unrelated to PR changes.
Only check internal links which are deterministic and catch real issues.

Change-Id: I6ac9560a0f3e357c490eb119fc146ba05ad91759
Copilot AI review requested due to automatic review settings May 18, 2026 10:56
@mergify mergify Bot deployed to Mergify Merge Protections May 18, 2026 10:56 Active
@jd jd marked this pull request as ready for review May 18, 2026 10:56
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 18, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify mergify Bot requested a review from a team May 18, 2026 10:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the broken-link CI check deterministic by configuring Linkinator to skip HTTP/HTTPS links and focus on local build output links.

Changes:

  • Updates check:links to skip external http/https URLs.
  • Removes retry and timeout settings that were mainly relevant to external network checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify mergify Bot requested a review from a team May 18, 2026 11:45
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 18, 2026

Merge Queue Status

mergify Bot added a commit that referenced this pull request May 18, 2026
@mergify mergify Bot added the queued label May 18, 2026
mergify Bot added a commit that referenced this pull request May 18, 2026
mergify Bot added a commit that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants