Skip to content

Conversation

@jd
Copy link
Member

@jd jd commented Jan 24, 2026

Consolidate the duplicated hooks directory resolution logic into a
single async helper function.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

@mergify mergify bot had a problem deploying to Mergify Merge Protections January 24, 2026 17:25 Failure
@jd
Copy link
Member Author

jd commented Jan 24, 2026

This pull request is part of a stack:

  1. refactor(stack): extract _get_hooks_dir() helper (#934) 👈
  2. refactor(stack): extract _get_script_resource_path() helper (#935)
  3. refactor(stack): use as_file() for package resource copying (#937)

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2026

🧪 CI Insights

Here's what we observed from your CI run for 2c041d4.

🟢 All jobs passed!

But CI Insights is watching 👀

@jd jd force-pushed the devs/jd/version-hooks/I45910d02a514ed45f8b6d0becf58d36dce2a51f5 branch from d2b3175 to 843ec91 Compare January 25, 2026 13:35
@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from 45260a8 to 41bf5c4 Compare January 25, 2026 13:35
@mergify mergify bot had a problem deploying to Mergify Merge Protections January 25, 2026 13:36 Failure
@jd jd force-pushed the devs/jd/version-hooks/I45910d02a514ed45f8b6d0becf58d36dce2a51f5 branch from 843ec91 to dd362a1 Compare January 25, 2026 14:32
@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from 41bf5c4 to e16a5ee Compare January 25, 2026 14:32
@mergify mergify bot had a problem deploying to Mergify Merge Protections January 25, 2026 14:33 Failure
@mergify mergify bot requested a review from a team January 25, 2026 14:34
remyduthu
remyduthu previously approved these changes Jan 26, 2026
@jd jd force-pushed the devs/jd/version-hooks/I45910d02a514ed45f8b6d0becf58d36dce2a51f5 branch from dd362a1 to c3dbb6e Compare January 26, 2026 12:53
@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from e16a5ee to 50c44f7 Compare January 26, 2026 12:53
@mergify mergify bot dismissed remyduthu’s stale review January 26, 2026 12:53

Pull request has been modified.

@mergify mergify bot had a problem deploying to Mergify Merge Protections January 26, 2026 12:53 Failure
@mergify mergify bot requested a review from a team January 26, 2026 12:55
@jd jd force-pushed the devs/jd/version-hooks/I45910d02a514ed45f8b6d0becf58d36dce2a51f5 branch from c3dbb6e to 22edf5f Compare January 26, 2026 13:13
@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from 50c44f7 to cafc24a Compare January 26, 2026 13:13
@mergify mergify bot had a problem deploying to Mergify Merge Protections January 26, 2026 13:13 Failure
Base automatically changed from devs/jd/version-hooks/I45910d02a514ed45f8b6d0becf58d36dce2a51f5 to main January 26, 2026 15:54
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2026

@jd this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Jan 26, 2026
Consolidate the duplicated hooks directory resolution logic into a
single async helper function.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change-Id: I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4
Claude-Session-Id: 3dabd187-059b-40b7-9a52-a2542a27c752
@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from cafc24a to 2c041d4 Compare January 26, 2026 15:56
@mergify mergify bot removed the conflict label Jan 26, 2026
@mergify mergify bot deployed to Mergify Merge Protections January 26, 2026 15:57 Active
mergify bot added a commit that referenced this pull request Jan 27, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

Merge Queue Status

✅ The pull request has been merged at 2c041d4

This pull request spent 1 minute 57 seconds in the queue, including 1 minute 43 seconds running CI.
The checks were run on draft #941.

Required conditions to merge

@mergify mergify bot added the queued label Jan 27, 2026
@mergify mergify bot merged commit a314b4c into main Jan 27, 2026
12 of 26 checks passed
@mergify mergify bot deleted the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch January 27, 2026 08:13
@mergify mergify bot removed the queued label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants