Feature filtering integration 3#4449
Merged
Withalion merged 3 commits intodev/filteringfrom Apr 14, 2026
Merged
Conversation
Coverage Report for CI Build 24346902857Coverage increased (+0.006%) to 58.502%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions60 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
tomasMizera
approved these changes
Apr 14, 2026
| @@ -173,14 +169,13 @@ QString FilterController::buildFieldExpression( const FieldFilter &filter ) cons | |||
| // so we must convert local datetimes to UTC before comparing. | |||
| // Use a custom format to avoid the 'Z' suffix that Qt::ISODate adds for UTC. | |||
| const QString isoFormat = QStringLiteral( "yyyy-MM-ddTHH:mm:ss" ); | |||
Collaborator
There was a problem hiding this comment.
Mind the upper bound for seconds (min: 0 seconds, max: 59 seconds, 999 miliseconds)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.