Allow adding a new part to multipart geometries#4496
Conversation
Coverage Report for CI Build 25923332422Coverage increased (+0.1%) to 58.031%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions107 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
| // if maptool is in GRAB and VIEW state, no part should be added | ||
| if ( mState == RecordingMapTool::View || mState == RecordingMapTool::Grab ) |
There was a problem hiding this comment.
I'm thinking View is a great state to add a new part
There was a problem hiding this comment.
The state is set to Record in qml before invoking this method. This is kind of a safeguard that the method doesn't get called properly.
Should I set the state in cpp and just call startDigitizingNewPart() from qml?
|
|
||
| function addPart( featurepair) { | ||
| __activeProject.setActiveLayer( featurepair.layer ) | ||
| root.centerToPair( featurepair ) |
There was a problem hiding this comment.
| root.centerToPair( featurepair ) |
I think this is a bad idea and would like to remove it (also from split and redraw logic).
User is centered to the geometry when identifying it, then if he has panned the map he is re-centered a second time when tapping Edit geometry.
I think it is very probable that the user has already panned the map to where he wants to add the new part / split / redraw and we're just forcing him back to the original geometry location!
|
@uclaros Actual result:
Expected result:
Screen_Recording_20260610_152928.mp4 |
New feature for adding parts to multipart features.
Works with MultiPoint, MultiLineString and MultiPolygon layers.
The button is not available for singlepart layers.