Skip to content

Value relation model and controller unit tests#4531

Open
gabriel-bolbotina wants to merge 3 commits into
fix/value-relation-2026from
value-relation-unit-tests
Open

Value relation model and controller unit tests#4531
gabriel-bolbotina wants to merge 3 commits into
fix/value-relation-2026from
value-relation-unit-tests

Conversation

@gabriel-bolbotina

Copy link
Copy Markdown
Contributor

Add VR lookup and ordering layer helpers to TestUtils.

For testFormEditors, removed the existing testValueRelationsEditor function and replaced it with 2 tests that check:

  • QGIS value format conversions (qgisFormatToArray / arrayToQgisFormat) for single and multi-select
  • VR controller async lookup: value-changed lookup, hotreload with filter context, and invalidateSelection

For testModels, replaced the empty tests with:

  • VR ordering: by key (asc/desc), by value, and by explicit field name
  • VR search: confirms search applies only to the value column, not the key
  • VR hotreload: manual reloadFeatures() after feature addition, and auto-reload via the layer editing signal

…ering layer

Added test cases for form editors suite for conversions and lookup
Added test cases for test models suite for ordering, search and hot reload
added order by field descending test case
@github-actions

Copy link
Copy Markdown

Coverage Report for CI Build 27261749506

Warning

No base build found for commit 6c58dce on fix/value-relation-2026.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 57.439%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15547
Covered Lines: 8930
Line Coverage: 57.44%
Coverage Strength: 96.67 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant