Add faceted type-ahead search capability to CSET web interface#1713
Merged
James Frost (jfrost-mo) merged 27 commits intomainfrom Apr 20, 2026
Merged
Add faceted type-ahead search capability to CSET web interface#1713James Frost (jfrost-mo) merged 27 commits intomainfrom
James Frost (jfrost-mo) merged 27 commits intomainfrom
Conversation
James Frost (jfrost-mo)
force-pushed
the
MSc_ui_improvements
branch
from
dcb8464 to
281677c
Compare
Contributor
|
|
James Frost (jfrost-mo)
changed the title
James Frost (jfrost-mo)
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Oct 28, 2025
Open
James Frost (jfrost-mo)
force-pushed
the
MSc_ui_improvements
branch
4 times, most recently
from
06d6e99 to
47e766b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
James Frost (jfrost-mo)
force-pushed
the
MSc_ui_improvements
branch
4 times, most recently
from
4edac77 to
7ed878c
Compare
James Frost (jfrost-mo)
force-pushed
the
MSc_ui_improvements
branch
2 times, most recently
from
25f9105 to
dff23c5
Compare
James Frost (jfrost-mo)
changed the base branch from
main
to
1049_cache_busting
James Frost (jfrost-mo)
force-pushed
the
MSc_ui_improvements
branch
from
3a00a7b to
e5c20e5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
James Frost (jfrost-mo)
force-pushed
the
MSc_ui_improvements
branch
from
e5c20e5 to
bc07f67
Compare
Pierre Siddall (Pierre-siddall)
left a comment
Pierre Siddall (Pierre-siddall)
left a comment
There was a problem hiding this comment.
This looks really good James, you've definitely had a good understanding of the lexer and have implemented clever regex to match the different range of search queries a user may input. Equally, you clearly have demonstrated that you know how the DOM functions by construing HTML elements being added to or removed from the DOM via javascript. I only have a couple of tiny improvements here regarding informative variable names in order to help future developers understand the control flow of your javascript by knowing what is being operated on. However, overall I think this is a well justified piece of work, great job :) .
Using more descriptive names clarifies what data is being used.
We now add the templated variables into the written out recipe.
The primary optimisation here is to batch the addition of elements to the DOM. This reduces the number of rerenders/layouts triggered and minimises the number of events fired. This is especially useful as uBlock Origin watches DOM mutations, which slows things down a lot.
James Frost (jfrost-mo)
force-pushed
the
MSc_ui_improvements
branch
2 times, most recently
from
66e6494 to
4725fde
Compare
Runs a localhost webserver in a separate thread for serving the content under test to make it self contained. Playwright is therefore added as a testing dependency.
This means the browser shall be installed in CI. Playwright won't redownload if already downloaded, but will update if needed.
These facets can only take a single value, are hard to interpret, and don't allow any selection that can't be done with category instead.
This is far more efficient, leading to lower memory usage, and faster performance. Rendering was still expensive, so to keep it performant the number of rendered diagnostics is limited to 500.
I keep accidentally git adding it. This symlink allows testing the web interface with real data during development.
This makes it more visible while the user is still near the filter controls.
When more than two Conditions were specified separated by implicit ANDs, Conditions would sometimes not apply. For example the query "a b c" would check for a and b, but not c. This was due to an incorrect array index increment inside the and parsing logic, which caused the next Condition after a pair of implicitly ANDed Conditions to be skipped.
James Frost (jfrost-mo)
force-pushed
the
MSc_ui_improvements
branch
from
f815f88 to
0957f76
Compare
It now remains visible even when scrolled down, so you know that you don't have the full list of results. We also use it to display a message while the diagnostics are loading.
This will potentially allow for theming in future, and lets us see the range of colours we are using to ensure consistency.
As it is a UI element we should use the UI font. The placeholder/plot pages have been felt alone, as they contain more prose for which san-serif is better.
David Flack (daflack)
approved these changes
Apr 15, 2026
Collaborator
David Flack (daflack)
left a comment
David Flack (daflack)
left a comment
There was a problem hiding this comment.
Having had a brief look at the example website provided, and tested the capability that was breaking and not as clear I find the changes really helpful and beneficial. Website looks really clear and easy to navigate with useful factors considered. Great job! (Probably want multiple approving reviews rather than just one for this PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSET output web interface improvements developed during my MSc project.
GitHub Copilot was used for review and fix suggestions for the prototype python parser, which was then hand ported to JavaScript. That code has been rebased away.
Thank you to Pierre Siddall (@Pierre-siddall) for reviewing the JavaScript code.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.