feat: add network fallback mechanism to IncomingTransactionHelper #7759
Conversation
…ingTransactionHelper
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.test.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Show resolved
Hide resolved
|
|
||
| this.#onInterval().catch((error) => { | ||
| log('Initial polling failed', error); | ||
| log('Polling failed', error); |
There was a problem hiding this comment.
This was intentional to distinguish that the first attempt failed, rather than a future interval based one.
| for (const caip2ChainId of chainIds) { | ||
| const hexChainId = this.#caip2ToHex(caip2ChainId); | ||
|
|
||
| if (!hexChainId || !SUPPORTED_CHAIN_IDS.includes(hexChainId)) { |
There was a problem hiding this comment.
Are we adding the dynamic supported chains via /supportedNetworks in a separate ticket?
There was a problem hiding this comment.
Can we add a log here for helpful debug, maybe separately if chain ID not recognised or if not supported?
There was a problem hiding this comment.
For dynamic chain support yes a separate task will be better as it will require changes in AccountsApiRemoteTransactionSource
I added log to the PR
| }); | ||
| } | ||
| } else if (!this.#chainsToPoll.includes(hexChainId)) { | ||
| // status === 'down' |
There was a problem hiding this comment.
Should we be explicit in case they ever add more statuses?
| } | ||
|
|
||
| if (!hasChanges) { | ||
| return; |
There was a problem hiding this comment.
Another log for good debug?
Explanation
In incoming transaction helper if any chain goes down on web sockets, start polling for it.
References
Fixes #12345
Checklist
Note
Medium Risk
Changes incoming transaction retrieval control flow by dynamically starting/stopping polling based on backend network status events, which could affect update frequency and chain coverage if status events or chain-ID parsing behave unexpectedly.
Overview
Adds a network fallback for WebSocket-based incoming transaction retrieval. When
isIncomingTransactionsUseWebsocketsEnabledis on,IncomingTransactionHelpernow subscribes toAccountActivityService:statusChanged, tracks which supported chains are currently "down", and starts/stops a polling loop accordingly; interval polls are scoped to only the affectedchainIds.Plumbs chain scoping through the remote fetch path.
RemoteTransactionSourceRequestgains optionalchainIds,AccountsApiRemoteTransactionSource.fetchTransactionsuses it (defaulting toSUPPORTED_CHAIN_IDS),TransactionControllerallows the new status event, and tests/changelog are updated to cover the fallback behavior.Written by Cursor Bugbot for commit efcd59e. This will update automatically on new commits. Configure here.