Skip to content

Conversation

@tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Jan 29, 2026

Explanation

subscription controller add clearLastSelectedPaymentMethod

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: adds a small, state-only helper to remove a cached payment method entry and includes unit coverage; no networking/auth/payment flows are modified.

Overview
Adds SubscriptionController.clearLastSelectedPaymentMethod(product) to remove a product’s entry from state.lastSelectedPaymentMethod (no-op if unset).

Includes new unit tests covering clearing behavior and undefined-state handling, and documents the addition in the subscription-controller changelog.

Written by Cursor Bugbot for commit f697aa6. This will update automatically on new commits. Configure here.

@tuna1207 tuna1207 marked this pull request as ready for review January 29, 2026 03:19
@tuna1207 tuna1207 requested review from a team as code owners January 29, 2026 03:19
chaitanyapotti
chaitanyapotti previously approved these changes Jan 29, 2026
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nicer to clone state, delete object and re-assign so that we don't need to change type interface

@tuna1207
Copy link
Member Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "4.0.0-preview-9c68b732",
  "@metamask-previews/accounts-controller": "35.0.2-preview-9c68b732",
  "@metamask-previews/address-book-controller": "7.0.1-preview-9c68b732",
  "@metamask-previews/ai-controllers": "0.0.0-preview-9c68b732",
  "@metamask-previews/analytics-controller": "1.0.0-preview-9c68b732",
  "@metamask-previews/analytics-data-regulation-controller": "0.0.0-preview-9c68b732",
  "@metamask-previews/announcement-controller": "8.0.0-preview-9c68b732",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-9c68b732",
  "@metamask-previews/approval-controller": "8.0.0-preview-9c68b732",
  "@metamask-previews/assets-controller": "0.0.0-preview-9c68b732",
  "@metamask-previews/assets-controllers": "99.0.0-preview-9c68b732",
  "@metamask-previews/base-controller": "9.0.0-preview-9c68b732",
  "@metamask-previews/bridge-controller": "65.1.0-preview-9c68b732",
  "@metamask-previews/bridge-status-controller": "65.0.1-preview-9c68b732",
  "@metamask-previews/build-utils": "3.0.4-preview-9c68b732",
  "@metamask-previews/chain-agnostic-permission": "1.4.0-preview-9c68b732",
  "@metamask-previews/claims-controller": "0.4.1-preview-9c68b732",
  "@metamask-previews/composable-controller": "12.0.0-preview-9c68b732",
  "@metamask-previews/connectivity-controller": "0.1.0-preview-9c68b732",
  "@metamask-previews/controller-utils": "11.18.0-preview-9c68b732",
  "@metamask-previews/core-backend": "5.0.0-preview-9c68b732",
  "@metamask-previews/delegation-controller": "2.0.0-preview-9c68b732",
  "@metamask-previews/earn-controller": "11.1.0-preview-9c68b732",
  "@metamask-previews/eip-5792-middleware": "2.1.0-preview-9c68b732",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-9c68b732",
  "@metamask-previews/eip1193-permission-middleware": "1.0.3-preview-9c68b732",
  "@metamask-previews/ens-controller": "19.0.2-preview-9c68b732",
  "@metamask-previews/error-reporting-service": "3.0.1-preview-9c68b732",
  "@metamask-previews/eth-block-tracker": "15.0.1-preview-9c68b732",
  "@metamask-previews/eth-json-rpc-middleware": "23.0.0-preview-9c68b732",
  "@metamask-previews/eth-json-rpc-provider": "6.0.0-preview-9c68b732",
  "@metamask-previews/foundryup": "1.0.1-preview-9c68b732",
  "@metamask-previews/gas-fee-controller": "26.0.2-preview-9c68b732",
  "@metamask-previews/gator-permissions-controller": "1.1.1-preview-9c68b732",
  "@metamask-previews/json-rpc-engine": "10.2.1-preview-9c68b732",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-9c68b732",
  "@metamask-previews/keyring-controller": "25.1.0-preview-9c68b732",
  "@metamask-previews/logging-controller": "7.0.1-preview-9c68b732",
  "@metamask-previews/message-manager": "14.1.0-preview-9c68b732",
  "@metamask-previews/messenger": "0.3.0-preview-9c68b732",
  "@metamask-previews/multichain-account-service": "5.1.0-preview-9c68b732",
  "@metamask-previews/multichain-api-middleware": "1.2.6-preview-9c68b732",
  "@metamask-previews/multichain-network-controller": "3.0.2-preview-9c68b732",
  "@metamask-previews/multichain-transactions-controller": "7.0.0-preview-9c68b732",
  "@metamask-previews/name-controller": "9.0.0-preview-9c68b732",
  "@metamask-previews/network-controller": "29.0.0-preview-9c68b732",
  "@metamask-previews/network-enablement-controller": "4.1.0-preview-9c68b732",
  "@metamask-previews/notification-services-controller": "21.0.0-preview-9c68b732",
  "@metamask-previews/permission-controller": "12.2.0-preview-9c68b732",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-9c68b732",
  "@metamask-previews/perps-controller": "0.0.0-preview-9c68b732",
  "@metamask-previews/phishing-controller": "16.1.0-preview-9c68b732",
  "@metamask-previews/polling-controller": "16.0.2-preview-9c68b732",
  "@metamask-previews/preferences-controller": "22.0.0-preview-9c68b732",
  "@metamask-previews/profile-metrics-controller": "3.0.0-preview-9c68b732",
  "@metamask-previews/profile-sync-controller": "27.0.0-preview-9c68b732",
  "@metamask-previews/ramps-controller": "5.0.0-preview-9c68b732",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-9c68b732",
  "@metamask-previews/remote-feature-flag-controller": "4.0.0-preview-9c68b732",
  "@metamask-previews/sample-controllers": "4.0.2-preview-9c68b732",
  "@metamask-previews/seedless-onboarding-controller": "7.1.0-preview-9c68b732",
  "@metamask-previews/selected-network-controller": "26.0.2-preview-9c68b732",
  "@metamask-previews/shield-controller": "5.0.0-preview-9c68b732",
  "@metamask-previews/signature-controller": "39.0.1-preview-9c68b732",
  "@metamask-previews/storage-service": "0.0.1-preview-9c68b732",
  "@metamask-previews/subscription-controller": "5.4.1-preview-9c68b732",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-9c68b732",
  "@metamask-previews/transaction-controller": "62.11.0-preview-9c68b732",
  "@metamask-previews/transaction-pay-controller": "12.0.1-preview-9c68b732",
  "@metamask-previews/user-operation-controller": "41.0.2-preview-9c68b732"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants