Skip to content

chore: bridge:submitTx calls the TransactionController's handlers through the messenger#8188

Merged
micaelae merged 32 commits intomainfrom
swaps3560-submitTx-handlers
Mar 19, 2026
Merged

chore: bridge:submitTx calls the TransactionController's handlers through the messenger#8188
micaelae merged 32 commits intomainfrom
swaps3560-submitTx-handlers

Conversation

@micaelae
Copy link
Member

@micaelae micaelae commented Mar 11, 2026

Explanation

This change replaces the transaction handlers provided to the BridgeStatusController constructor with calls to the TransactionController, through the controller messenger

To migrate:

  • Clients will need to add the TransactionControllerUpdateTransactionAction, TransactionControllerAddTransactionAction, and TransactionControllerEstimateGasFeeAction permissions to their controller init modules in addition to updating the constructor
  • They will also need to remove the transaction handlers from the BridgeStatusController constructor

References

Fixes https://consensyssoftware.atlassian.net/browse/SWAPS-3560

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

High Risk
Breaking API change that alters how BridgeStatusController submits/updates transactions and estimates gas by routing through TransactionController messenger actions, which can impact transaction creation, gas fee calculation, and batching behavior if permissions/messenger wiring are incorrect.

Overview
BREAKING: BridgeStatusController no longer accepts injected transaction handlers (addTransactionFn, updateTransactionFn, estimateGasFeeFn) and instead performs addTransaction, updateTransaction, and estimateGasFee via messenger.call to TransactionController actions (constructor signature and required permissions updated).

Gas-fee calculation utilities and batch-type post-processing were updated to use the messenger-based estimateGasFee/updateTransaction calls, and tests/snapshots were refactored accordingly to assert the new messenger call sequences (including intent polling updates via TransactionController:updateTransaction).

Written by Cursor Bugbot for commit 31816a7. This will update automatically on new commits. Configure here.

Base automatically changed from swaps4229-refactor-bridge-status-test-coverage to main March 12, 2026 16:16
@micaelae micaelae changed the title Swaps3560 submit tx handlers chore: bridge.submitTx calls the TransactionController's handlers through the messenger Mar 17, 2026
@micaelae micaelae changed the title chore: bridge.submitTx calls the TransactionController's handlers through the messenger chore: bridge:submitTx calls the TransactionController's handlers through the messenger Mar 17, 2026
@micaelae micaelae marked this pull request as ready for review March 17, 2026 20:54
@micaelae micaelae requested review from a team as code owners March 17, 2026 20:54
@micaelae micaelae enabled auto-merge March 17, 2026 20:59
@micaelae micaelae force-pushed the swaps3560-submitTx-handlers branch from 950e053 to 0550c87 Compare March 18, 2026 16:09
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@micaelae micaelae removed the request for review from a team March 18, 2026 17:25
@micaelae micaelae added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 9ec5646 Mar 19, 2026
326 checks passed
@micaelae micaelae deleted the swaps3560-submitTx-handlers branch March 19, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants