chore: Update Delegation controllers to expose all methods through messenger #8205
Open
chore: Update Delegation controllers to expose all methods through messenger #8205
Conversation
mcmire
reviewed
Mar 16, 2026
Contributor
mcmire
left a comment
There was a problem hiding this comment.
A couple of things, but otherwise looks good.
694e1d8 to
3aba88d
Compare
mcmire
reviewed
Mar 17, 2026
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
6fd6620 to
d3257e4
Compare
GuillaumeRx
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This updates the following controllers to expose all methods through the messenger in a standardised way:
DelegationController.GatorPermissionsController.References
Checklist
Note
Medium Risk
Expands each controller’s public messenger surface area and changes how actions are registered/called, which could affect downstream consumers relying on previous action typings/exports, though core logic is largely unchanged.
Overview
Standardizes messenger exposure for
DelegationControllerandGatorPermissionsControllerby registering all public methods viamessenger.registerMethodActionHandlersand adding generated*-method-action-types.tsunions for the corresponding action types.Updates exports/types so
DelegationControllerGetStateActionand the new method-action types are publicly available, and refactors tests to invoke controller behavior throughrootMessenger.call(...)rather than direct method calls. Addstsxplus agenerate-method-action-typesscript to both packages and records the API exposure in changelogs.Written by Cursor Bugbot for commit d3257e4. This will update automatically on new commits. Configure here.