chore: Update Web3Auth controllers to expose all methods through messenger#8219
Open
chore: Update Web3Auth controllers to expose all methods through messenger#8219
Conversation
mcmire
reviewed
Mar 17, 2026
| export type SeedlessOnboardingControllerOptions< | ||
| EncryptionKey, | ||
| SupportedKeyDerivationParams, | ||
| EncryptionKey = encryptionUtils.EncryptionKey, |
Contributor
There was a problem hiding this comment.
Why is it necessary to change this?
Member
Author
There was a problem hiding this comment.
The extraction script assumes we can use Controller['method'], but without these defaults that would result in a TypeScript error because the type parameters are missing.
Contributor
There was a problem hiding this comment.
Ah, right, I see. That makes sense.
8755821 to
c1e8245
Compare
GuillaumeRx
previously approved these changes
Mar 18, 2026
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
3fa2720 to
f18b535
Compare
GuillaumeRx
approved these changes
Mar 19, 2026
Contributor
|
Looks good, other than the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This updates the following controllers to expose all methods through the messenger in a standardised way:
SeedlessOnboardingController.ShieldController.SubscriptionController.ClaimsController.References
Checklist
Note
Medium Risk
Expands the messenger API surface for controllers (including seedless onboarding/auth flows), which could affect consumers and access patterns if action names/types are miswired. Core logic appears unchanged, but messaging wiring errors would break controller calls at runtime.
Overview
Exposes all public methods on
ClaimsControllerandSeedlessOnboardingControllerthrough their messengers by registering method handlers and introducing auto-generated*-method-action-types.tstype unions for the new action names.Updates
@metamask/claims-controllerexports to re-export the new action types, adds agenerate-method-action-typesscript (andtsxdevDependency) to both packages, and adjustsClaimsControllertests to call methods viarootMessenger.call('Controller:method', ...)instead of invoking controller methods directly. Changelogs are updated to document the newly available messenger actions and exported action types.Written by Cursor Bugbot for commit f18b535. This will update automatically on new commits. Configure here.