fix: auto-remove NFTs from state when backend reclassifies them as spam#8237
Open
fix: auto-remove NFTs from state when backend reclassifies them as spam#8237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Introduces a breaking constructor change and new state-mutation behavior (automatic NFT removals) during detection, which could affect integrators and unexpectedly prune user-visible assets if inputs/network resolution are wrong.
Overview
NftDetectionController.detectNfts()now actively removes NFTs already in local state when the NFT API returns them withisSpam: true, usingNetworkController:findNetworkClientIdByChainIdto resolve the target network and skipping removals when the network can’t be resolved.This is a breaking change: the
NftDetectionControllerconstructor now requires aremoveNftcallback (wired toNftController.removeNft). Tests and the package changelog were updated to cover/announce the new spam-removal behavior and edge cases.Written by Cursor Bugbot for commit 707ea93. This will update automatically on new commits. Configure here.