Skip to content

Prohibit cross-package relative imports #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 8 commits into from
Mar 19, 2026
+34 −0
Merged

Prohibit cross-package relative imports #8238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
58abcdf
Prohibit cross-package relative imports
mcmire Mar 18, 2026
ebb0ad2
Update suppressions file
mcmire Mar 18, 2026
ec3ac24
Fix Prettier violation
mcmire Mar 18, 2026
65ad80e
Use no-relative-packages instead of a custom rule
mcmire Mar 18, 2026
c6ce13c
Merge branch 'main' into prohibit-cross-package-imports
mcmire Mar 19, 2026
b9e30ce
Prune suppression
mcmire Mar 19, 2026
6319b41
Remove outdated comment, and move the rule down
mcmire Mar 19, 2026
c1a516e
Update comment
mcmire Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@
"count": 6
}
},
"packages/assets-controller/src/__fixtures__/MockAssetControllerMessenger.ts": {
Copy link
Contributor Author

@mcmire mcmire Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these files should be in src/, they should probably be in tests/ instead, but we can address that in another PR.

"import-x/no-relative-packages": {
"count": 1
}
},
"packages/assets-controllers/jest.environment.js": {
"n/prefer-global/text-decoder": {
"count": 1
Expand Down Expand Up @@ -251,13 +256,21 @@
"id-length": {
"count": 1
},
"import-x/no-relative-packages": {
"count": 1
},
"no-negated-condition": {
"count": 1
},
"no-param-reassign": {
"count": 2
}
},
"packages/assets-controllers/src/NftDetectionController.ts": {
"import-x/no-relative-packages": {
"count": 1
}
},
"packages/assets-controllers/src/RatesController/RatesController.test.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 1
Expand Down Expand Up @@ -614,6 +627,9 @@
"packages/bridge-status-controller/src/utils/transaction.ts": {
"@typescript-eslint/prefer-nullish-coalescing": {
"count": 1
},
"import-x/no-relative-packages": {
"count": 1
}
},
"packages/chain-agnostic-permission/src/caip25Permission.ts": {
Expand Down Expand Up @@ -1689,6 +1705,16 @@
"count": 2
}
},
"packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts": {
"import-x/no-relative-packages": {
"count": 1
}
},
"packages/transaction-pay-controller/src/utils/source-amounts.ts": {
"import-x/no-relative-packages": {
"count": 1
}
},
"packages/user-operation-controller/src/UserOperationController.test.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 6
Expand Down
8 changes: 8 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,14 @@ const config = createConfig([
sourceType: 'module',
},
},
// Prevent cross-package relative imports
{
files: ['packages/*/src/**/*.ts'],
ignores: ['**/*.test.ts', '**/tests/**/*.ts'],
rules: {
'import-x/no-relative-packages': 'error',
},
},
{
files: ['packages/foundryup/**/*.{js,ts}'],
rules: {
Expand Down
Loading