feat: add sortAccountIdsByLastSelected to getSessionScopes, wallet_getSession, and wallet_createSession#8255
Open
feat: add sortAccountIdsByLastSelected to getSessionScopes, wallet_getSession, and wallet_createSession#8255
Conversation
Member
Author
|
@metamaskbot preview-build |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
@metamask/chain-agnostic-permissionsortAccountIdsByLastSelectedparameter togetSessionScopesfunction(accounts: CaipAccountId[]) => CaipAccountId[]accountsarray within each scope (both required and optional scopes)@metamask/multichain-api-middlewaresortAccountIdsByLastSelectedhook towallet_getSessionhandlergetSessionScopeswhen building session responsesortAccountIdsByLastSelectedhook towallet_createSessionhandlergetSessionScopeswhen building session scopes for approvalReferences
See: MetaMask/metamask-extension#41068
Checklist
Note
Medium Risk
Medium risk because it changes the public hook/API surface for
wallet_getSession/wallet_createSession(new required hook) and can reorder returnedaccounts, which could affect consumers that rely on stable ordering.Overview
Adds an optional
sortAccountIdsByLastSelectedhook to@metamask/chain-agnostic-permissiongetSessionScopes, applying it to theaccountsarray for each scope (required and optional) when building normalized session scopes.Updates
@metamask/multichain-api-middlewarewallet_getSessionandwallet_createSessionhandlers to require and forward this hook, with tests and changelogs updated to cover the new sorting behavior and hook requirement.Written by Cursor Bugbot for commit f3055a7. This will update automatically on new commits. Configure here.