fix: skip already-aligned accounts during wallet alignment#9269
Open
mathieuartu wants to merge 3 commits into
Open
fix: skip already-aligned accounts during wallet alignment#9269mathieuartu wants to merge 3 commits into
mathieuartu wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1939
Checklist
Note
Medium Risk
Changes core wallet alignment and account creation orchestration, but behavior is narrowed (less work, same end goal) and is covered by expanded alignment tests.
Overview
Wallet alignment no longer calls
createAccountsfor every provider across the full group index range. It now derives per-provider contiguous sub-ranges of missing(provider, group index)pairs and only invokes providers for those gaps; fully aligned providers are skipped entirely.MultichainAccountGroupgainsisProviderAligned(provider), andisAligned()delegates to it. Shared group-state building is refactored from#buildGroupStateForRangeto#buildGroupStatewith agetSubRangescallback: creation still passes the full[from, to]range; alignment uses#getUnalignedSubRangesForProvider(missing groups count as unaligned). Tests cover partial gaps, skipping aligned providers, and non-contiguous missing indices; the changelog documents the fix.Reviewed by Cursor Bugbot for commit 7d30943. Bugbot is set up for automated code reviews on this repo. Configure here.