Open
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3903 +/- ##
=======================================
Coverage 98.55% 98.56%
=======================================
Files 425 425
Lines 12358 12381 +23
Branches 1935 1938 +3
=======================================
+ Hits 12180 12203 +23
Misses 178 178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adding capabilities to the keyring endowment as part of keyring v2 work (https://github.com/MetaMask/decisions/blob/main/decisions/core/0006-keyring-interface.md)
Note
Medium Risk
Expands the
endowment:keyringpermission/manifest surface with a new validated caveat, which could impact permission granting/validation and downstream keyring behavior if mis-specified or inconsistently interpreted.Overview
Adds optional
capabilitiessupport to theendowment:keyringpermission by introducing a newkeyringCapabilitiescaveat, updating the endowment specification/mapper, and exportinggetKeyringCaveatCapabilitiesto read it from permissions.Updates
@metamask/snaps-utilsto includeSnapCaveatType.KeyringCapabilitiesplus a newKeyringCapabilitiesStruct/assertIsKeyringCapabilities, and extends manifest validation and SDKInitialPermissionstypings to accept acapabilitiesobject underendowment:keyring. Tests and snapshots are updated accordingly (plus minor coverage threshold bump).Written by Cursor Bugbot for commit 5f1946d. This will update automatically on new commits. Configure here.