Skip to content

Fix return code for fw-read and log-parse commands #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parithi098 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix return code for fw-read and log-parse commands #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions cli/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,10 +1200,15 @@ static int log_parse(int argc, char **argv)
cfg.parsed_log_file, cfg.log_type,
cfg.gen, &info);
if (ret < 0)
{
switchtec_perror("log_parse");
}
else
fprintf(stderr, "\nParsed log saved to %s.\n",
cfg.parsed_log_filename);
{
fprintf(stderr, "\nParsed log saved to %s.\n", cfg.parsed_log_filename);
/* return 0 for command success */
ret = 0;
}

if (info.version_mismatch && cfg.log_type != SWITCHTEC_LOG_PARSE_TYPE_FTDC) {
fprintf(stderr, "\nWARNING: The two input files have different version numbers.\n");
Expand Down Expand Up @@ -1974,9 +1979,15 @@ static int fw_read(int argc, char **argv)
progress_finish(cfg.no_progress_bar);

if (ret < 0)
{
switchtec_perror("fw_read");

fprintf(stderr, "\nFirmware read to %s.\n", cfg.out_filename);
}
else
{
fprintf(stderr, "\nFirmware read to %s.\n", cfg.out_filename);
/* return 0 for command success */
ret = 0;
}

switchtec_fw_part_summary_free(sum);

Expand Down