shock_spectrum displays aggregate_axes correctly on larger datasets#236
Merged
JSMTHWCK merged 2 commits intodevelopmentfrom Mar 31, 2026
Merged
shock_spectrum displays aggregate_axes correctly on larger datasets#236JSMTHWCK merged 2 commits intodevelopmentfrom
JSMTHWCK merged 2 commits intodevelopmentfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #236 +/- ##
============================================
Coverage 71.36% 71.36%
============================================
Files 35 35
Lines 3279 3279
============================================
Hits 2340 2340
Misses 939 939 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
StokesMIDE
approved these changes
Feb 25, 2026
Member
StokesMIDE
left a comment
StokesMIDE
left a comment
There was a problem hiding this comment.
The codecov failure isn't related to this PR, so I'm ignoring it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed problem where calc.shock_spectrum(aggregate_axes = True) was returning unnecessary axes for larger inputs