Ticket #5062: Ignore mouse click on a menu's separator line#5064
Open
egmontkob wants to merge 1 commit intoMidnightCommander:masterfrom
Open
Ticket #5062: Ignore mouse click on a menu's separator line#5064egmontkob wants to merge 1 commit intoMidnightCommander:masterfrom
egmontkob wants to merge 1 commit intoMidnightCommander:masterfrom
Conversation
github-actions
bot
added
needs triage
zyv
added
area: tty
zyv
approved these changes
Mar 11, 2026
zyv
added
area: core
mc-worker
approved these changes
Mar 12, 2026
| return FALSE; | ||
|
|
||
| menu = MENU (g_list_nth_data (menubar->menu, menubar->current)); | ||
| entry = MENUENTRY (g_list_nth_data (menu->entries, y - 2)); |
Contributor
There was a problem hiding this comment.
If entry is NULL, we can immediately return FALSE. Following calculations are not make sense in this case.
…or line Signed-off-by: Egmont Koblinger <egmont@gmail.com>
egmontkob
force-pushed
the
5062-menu-click-on-separator
branch
from
07be1f9 to
0238700
Compare
Member
|
|
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Ignore mouse click on a menu's separator line
Checklist
👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈
git commit --amend -smake indent && make check)