Draft: Implement a basic artifact attributes API#14
Draft
KitsuneAlex wants to merge 3 commits intoMinecraftForge:masterfrom
Draft
Draft: Implement a basic artifact attributes API#14KitsuneAlex wants to merge 3 commits intoMinecraftForge:masterfrom
KitsuneAlex wants to merge 3 commits intoMinecraftForge:masterfrom
Conversation
…tion detail to allow ArtifactAttribute#create to be implemented
LexManos
reviewed
Sep 16, 2024
| @@ -1,5 +1,5 @@ | |||
| Artifactural | |||
| Copyright (c) 2018-2021. | |||
Member
There was a problem hiding this comment.
Wow this hasn't been built in quite some time.
We've moved to the SPDX header format in modern projects for this exact reason.
Having times in the header isn't necessary anymore.
https://github.com/MinecraftForge/InstallerTools/blob/master/LICENSE-header.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a simple attribute system which allows attaching various "user-data" to artifact (identifiers).
This is going to be used in my PR for ForgeGradle which re-implement the deobfuscation repo artifact resolution using Gradle dependency attributes. Said dependency attributes are forwarded through the Artifactural API this way and allow matching repository artifacts based on dependency attributes.