fix: mismatch in roundtrip#168
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Confidence Score: 5/5Safe to merge — the change is a minimal, targeted correction of a read/write mode mismatch with no side effects. The two-line fix directly aligns load_from_disk with save: both now use binary I/O, which is what orjson expects. No logic is altered, and orjson.loads already handles bytes input, so the roundtrip is now fully consistent for any content including non-ASCII. No files require special attention. Reviews (2): Last reviewed commit: "up version" | Re-trigger Greptile |
Pringled
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We stored bytes but read them as non-bytes. This is fine for most code, since code is often just ASCII, but would crash on non-ascii
closes #167