Skip to content

GEOPY-2594: PGI failure on petrophysical model with air cells#367

Merged
domfournier merged 6 commits intodevelopfrom
GEOPY-2594
Mar 27, 2026
Merged

GEOPY-2594: PGI failure on petrophysical model with air cells#367
domfournier merged 6 commits intodevelopfrom
GEOPY-2594

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented Mar 25, 2026

GEOPY-2594 - PGI failure on petrophysical model with air cells

Copilot AI review requested due to automatic review settings March 25, 2026 15:07
@github-actions github-actions bot changed the title GEOPY-2594 GEOPY-2594: PGI failure on petrophysical model with air cells Mar 25, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates SimPEG drivers to better handle referenced/value-mapped data types during model interpolation and adjusts FDEM UI JSON dependencies so uncertainty fields are disabled/enabled (rather than shown/hidden) based on channel selection.

Changes:

  • Extend obj_2_mesh missing-value handling to include ReferencedValueMapType.
  • Update FDEM/FDEM1D inversion UI JSON so uncertainty inputs are controlled via "dependencyType": "enabled" and default to disabled.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
simpeg_drivers/components/models.py Expands value-map type detection in obj_2_mesh to treat 0 as missing for referenced/value-mapped data.
simpeg_drivers-assets/uijson/fdem_inversion.ui.json Switches uncertainty field dependencies from show to enabled and sets them initially disabled.
simpeg_drivers-assets/uijson/fdem1d_inversion.ui.json Same dependency behavior change for 1D FDEM uncertainty fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.88%. Comparing base (b1ad7f4) to head (fae0697).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #367      +/-   ##
===========================================
+ Coverage    89.85%   89.88%   +0.03%     
===========================================
  Files          125      125              
  Lines         6437     6437              
  Branches       794      794              
===========================================
+ Hits          5784     5786       +2     
+ Misses         449      448       -1     
+ Partials       204      203       -1     
Files with missing lines Coverage Δ
simpeg_drivers/components/models.py 91.44% <100.00%> (+0.58%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

benk-mira
benk-mira previously approved these changes Mar 25, 2026
@domfournier domfournier merged commit 7033425 into develop Mar 27, 2026
19 checks passed
@domfournier domfournier deleted the GEOPY-2594 branch March 27, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants