Vendor google/api protos, update proto codegen, and begin RPC naming alignment#39
Merged
MisterVVP merged 1 commit intoMay 13, 2026
Conversation
51c1042
into
dev-implement-ci-workflow-from-task-1-tck
1 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
a2a.protoimportsgoogle/api/*.protosymbols which were missing and causedprotoc/build failures; vendoring minimalgoogle/apiprotos fixes the immediate import errors so codegen can run locally.a2a.pb.h/.ccincludes resolve during build.Description
google/apiproto definitions intothird_party/googleapis/google/api/(annotations.proto,client.proto,field_behavior.proto,http.proto) soimport "google/api/..."resolves locally.proto/CMakeLists.txtto add--proto_path=${A2A_GOOGLEAPIS_PROTO_ROOT}, include the vendored google/api files in theprotocinvocation, and generate/compile their.pb.cc/.pb.halongsidea2a.protooutputs into thea2a_proto_generatedlibrary.SetTaskPushNotificationConfigtoCreateTaskPushNotificationConfig(representative files changed:include/a2a/*,src/*,examples/*,tests/*).a2a.protothat still require code updates).Testing
cmake -S . -B build -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS=ONand configuration succeeded.clang-format --dry-run --Werroron tracked C/C++ files and it passed for the touched files../scripts/verify_changes.sh;protoccodegen anda2a_proto_codegencompleted and C++ proto generation succeeded, but./scripts/verify_changes.shultimately failed because of broader upstream proto/schema incompatibilities (missing/renamed fields and enums in the newa2a.proto) that require a follow-up compatibility sweep; build progressed much further than before (the original import errors are resolved) but the full test/lint pipeline did not finish green.Codex Task