Align discovery and transport code with updated proto schema#40
Open
MisterVVP wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
transportto stringprotocol_bindingand movedprotocol_versionto per-interface, so discovery/transport code must be updated to match the new contract.history_lengthint32and security requirements were reshaped, requiring validation and parsing updates across client/server code and examples.Description
protocol_bindingand per-interfaceprotocol_version, includingIsValidInterfaceEndpoint,ToPreferredTransport,ToWireTransport, and validation helpers insrc/client/discovery.cpp.protocol_versionwhen missing insrc/server/rest_server_transport.cppand adjusted REST request parsing to parsehistoryLengthas an integer (src/server/rest_transport.cpp).history_lengthas an optionalint32and serialize it viastd::to_stringinsrc/client/http_json_transport.cpp.Roleenum usage andPart.textAPI, protocol binding strings, and security requirement map form) inexamples/example_support.handtests/unit/discovery_test.cpp.include/a2a/client/*.h) and gRPC transport implementation formatting insrc/client/grpc_transport.cpp.Testing
./scripts/run_clang_format.shwhich completed (formatting applied where needed) and then ran./scripts/verify_changes.shmultiple times during the migration; the verification run aborted due to build/test compilation errors in integration tests../scripts/verify_changes.shrun failed during the build stage with the following representative errors (excerpt):./scripts/verify_changes.shfailed, full TCK validation was not executed; this PR is an in-progress migration that compiles most core and unit targets but leaves remaining integration tests and a few call sites to be updated to the new proto contract.Codex Task