Open
Conversation
adincebic
force-pushed
the
adin/integrate-rsync-from-bcr
branch
from
905287e to
d47f5ab
Compare
adincebic
force-pushed
the
adin/integrate-rsync-from-bcr
branch
from
b1398d2 to
69a75c9
Compare
|
This is really cool! |
adincebic
force-pushed
the
adin/integrate-rsync-from-bcr
branch
from
69a75c9 to
3f237c7
Compare
Contributor
Author
|
@brentleyjones can you review again? This would be good to have in the next release. |
|
This would be really awesome to land. Thanks again for doing this. |
brentleyjones
approved these changes
Mar 12, 2026
Contributor
|
Please rebase and add it to the |
Contributor
Author
I'll deal with this today. |
adincebic
force-pushed
the
adin/integrate-rsync-from-bcr
branch
from
f6c6bab to
274b4e1
Compare
Contributor
Author
|
@brentleyjones done. |
adincebic
force-pushed
the
adin/integrate-rsync-from-bcr
branch
2 times, most recently
from
4ebaea0 to
0d45120
Compare
adincebic
force-pushed
the
adin/integrate-rsync-from-bcr
branch
from
0d45120 to
887e5ef
Compare
Signed-off-by: Adin Cebic <cebic.ad@gmail.com>
Signed-off-by: Adin Cebic <cebic.ad@gmail.com>
Signed-off-by: Adin Cebic <cebic.ad@gmail.com>
Signed-off-by: Adin Cebic <cebic.ad@gmail.com>
brentleyjones
force-pushed
the
adin/integrate-rsync-from-bcr
branch
from
887e5ef to
d53a731
Compare
| ### Adjusted | ||
|
|
||
| * Added support for Bazel 9: [#3286](https://github.com/MobileNativeFoundation/rules_xcodeproj/pull/3286) | ||
| * Integrated [Samba rsync](https://rsync.samba.org) from BCR so that users no longer need to install it via homebrew: [#3265](https://github.com/MobileNativeFoundation/rules_xcodeproj/pull/3265) |
Contributor
There was a problem hiding this comment.
Can you move this up to the correct section (looks like a rebase moved it)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrating rsync from BCR to stop relying on system
rsync/ homebrewrsync. We allow users to rely on homebrewrsyncever since the issue withopenrsyncon maCOS popped up. This fixes that.