Fix: map page sidebar covers fixed header on scroll#68
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The StyledMapControlPanel had zIndex: 10000 (needed for mobile full-screen overlay) but this was not reset for desktop (md) breakpoint. On desktop the panel has position: relative, so the high z-index created a stacking context that rendered above the fixed AppBar header (z-index 1100) when scrolling. Fix: add zIndex: 'auto' to the md breakpoint to restore normal document stacking order on desktop. Closes #57 Co-authored-by: Alessandro100 <18631060+Alessandro100@users.noreply.github.com>
Alessandro100
left a comment
There was a problem hiding this comment.
Tested on preview and it works, solution is simple
|
*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/ * (Desktop)
*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/feeds * (Desktop)
*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
|
closes #57
StyledMapControlPanelsetszIndex: 10000at the base level (required for the mobile full-screen overlay), but this was never reset for the desktop (md) breakpoint. On desktop the panel usesposition: relative, which combined with an explicit z-index creates a stacking context that sits above the MUIAppBar(z-index 1100). Scrolling the page causes the sidebar to render over the fixed header.Change
Add
zIndex: 'auto'to themdbreakpoint override inStyledMapControlPanel, removing the high-z stacking context on desktop:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
download.cypress.io/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node index.js --exec install(dns block)/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node dist/index.js --exec install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.