Skip to content

Fix: map page sidebar covers fixed header on scroll#68

Merged
Alessandro100 merged 2 commits intomainfrom
copilot/fix-ticket-57-issue
Mar 10, 2026
Merged

Fix: map page sidebar covers fixed header on scroll#68
Alessandro100 merged 2 commits intomainfrom
copilot/fix-ticket-57-issue

Conversation

Copy link
Contributor

Copilot AI commented Mar 10, 2026

closes #57

StyledMapControlPanel sets zIndex: 10000 at the base level (required for the mobile full-screen overlay), but this was never reset for the desktop (md) breakpoint. On desktop the panel uses position: relative, which combined with an explicit z-index creates a stacking context that sits above the MUI AppBar (z-index 1100). Scrolling the page causes the sidebar to render over the fixed header.

Change

Add zIndex: 'auto' to the md breakpoint override in StyledMapControlPanel, removing the high-z stacking context on desktop:

[theme.breakpoints.up('md')]: {
  display: 'flex',
  width: '300px',
  position: 'relative',
  top: 'unset',
  paddingTop: 0,
  margin: theme.spacing(2),
  zIndex: 'auto', // reset so the fixed header remains on top during scroll
},

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io
    • Triggering command: /opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node index.js --exec install (dns block)
    • Triggering command: /opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node dist/index.js --exec install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mobilitydatabase-web Ready Ready Preview, Comment Mar 10, 2026 0:38am

Request Review

The StyledMapControlPanel had zIndex: 10000 (needed for mobile full-screen
overlay) but this was not reset for desktop (md) breakpoint. On desktop the
panel has position: relative, so the high z-index created a stacking context
that rendered above the fixed AppBar header (z-index 1100) when scrolling.

Fix: add zIndex: 'auto' to the md breakpoint to restore normal document
stacking order on desktop.

Closes #57

Co-authored-by: Alessandro100 <18631060+Alessandro100@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with incorrect routing display Fix: map page sidebar covers fixed header on scroll Mar 10, 2026
Copy link
Contributor

@Alessandro100 Alessandro100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on preview and it works, solution is simple

@github-actions
Copy link

*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 93 🟢 96 🟢 100 🟢 100

*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 88 🟠 87 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🔴 41 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 77 🟠 83 🟢 100 🟢 100

*Lighthouse ran on https://mobilitydatabase-l73xos93d-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 91 🟢 94 🟢 96 🟢 100

@Alessandro100 Alessandro100 marked this pull request as ready for review March 10, 2026 13:33
@Alessandro100 Alessandro100 merged commit def8637 into main Mar 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feed Detail Map page: on scroll, side bar covers the header

3 participants