Skip to content

[222_63] 大纲拓展编号,性能优化#3037

Open
Yuki-Nagori wants to merge 7 commits intomainfrom
yuki/222_63/outline
Open

[222_63] 大纲拓展编号,性能优化#3037
Yuki-Nagori wants to merge 7 commits intomainfrom
yuki/222_63/outline

Conversation

@Yuki-Nagori
Copy link
Copy Markdown
Contributor

No description provided.

"将字符串重复n次"
(let loop ((i n) (acc ""))
(if (<= i 0)
acc
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

函数内部的中文 docstring(如 "检查字符串是否以指定后缀结尾")属于接口文档,按风格指南应写在测试文件中,实现文件只放实现细节相关的注释。

另外,代码中有一些行的长度超过 100 字符限制,建议拆分。

Copy link
Copy Markdown
Contributor

@MoonL79 MoonL79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #3037 Review - [222_63] 大纲拓展编号,性能优化

功能实现清晰,缓存机制设计合理,性能优化思路明确。

已在对应行留了具体意见,主要关注点:

  1. 函数内部的中文 docstring(如 "检查字符串是否以指定后缀结尾")属于接口文档,按风格指南应写在测试文件中
  2. 部分行长度超过 100 字符限制,建议拆分

Scheme 代码右括号标记规范,命名清晰。增量缓存设计考虑周全。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants